JS: Added support for [Object, Map].groupBy ES2024 feature #18008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Napalys
force-pushed
the
napalys/ES2024-group-functions
branch
from
f9096dc
to
a957e00
Compare
erik-krogh
reviewed
Nov 21, 2024
Co-authored-by: Erik Krogh Kristensen <[email protected]>
erik-krogh
approved these changes
Nov 21, 2024
|
DCA looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added taint-steps for ES2024 features:
Map.groupByObject.groupByDCA analyses shows that overall time is fine.